Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] #50 반려견 등록 페이지 기능 완성 #96

Merged
merged 10 commits into from
Nov 27, 2024
Merged

[Feature] #50 반려견 등록 페이지 기능 완성 #96

merged 10 commits into from
Nov 27, 2024

Conversation

wonill
Copy link
Collaborator

@wonill wonill commented Nov 27, 2024 •
edited
Loading

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE : #50

백엔드와의 통신 부분을 제외한 반려견 등록 페이지의 기능을 모두 완성했습니다.

🖼️ Screenshots

반려견프로필추가
가족반려견

@wonill wonill linked an issue Nov 27, 2024 that may be closed by this pull request
[Feature] 반려견 상세정보 입력 기능 #50
Closed
@wonill wonill changed the title 50 feature/add dog detail profile [Feature] #50 반려견 등록 페이지 기능 완성 Nov 27, 2024
@github-actions GitHub Actions
Copy link

⚡ Lighthouse Reports

http://localhost:4173/

Performance Metrics

Category Score
Performance 🟠 83
Accessibility 🟢 95
Best Practices 🟢 100
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.2 s
Largest Contentful Paint 🔴 4.1 s
Total Blocking Time 🟢 110 ms
Cumulative Layout Shift 🟢 0.008
Speed Index 🟢 2.2 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/log

Performance Metrics

Category Score
Performance 🟠 89
Accessibility 🟢 95
Best Practices 🟢 100
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟢 1.6 s
Largest Contentful Paint 🟠 3.7 s
Total Blocking Time 🟢 20 ms
Cumulative Layout Shift 🟢 0
Speed Index 🟢 1.6 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/login

Performance Metrics

Category Score
Performance 🟢 95
Accessibility 🟢 97
Best Practices 🟢 100
SEO 🟢 92

Detailed Metrics

Metric Value
First Contentful Paint 🟢 1.6 s
Largest Contentful Paint 🟠 2.8 s
Total Blocking Time 🟢 10 ms
Cumulative Layout Shift 🟢 0.006
Speed Index 🟢 1.6 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/mypage

Performance Metrics

Category Score
Performance 🟠 82
Accessibility 🟢 95
Best Practices 🟢 100
SEO 🟢 92

Detailed Metrics

Metric Value
First Contentful Paint 🟠 1.9 s
Largest Contentful Paint 🔴 4.7 s
Total Blocking Time 🟢 30 ms
Cumulative Layout Shift 🟢 0.002
Speed Index 🟢 1.9 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

@wonill wonill enabled auto-merge November 27, 2024 03:38
@wonill wonill merged commit c4500e1 into develop Nov 27, 2024
2 checks passed
@github-actions github-actions bot deleted the 50-feature/add-dog-detail-profile branch December 5, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruehan ruehan ruehan approved these changes

@shlee9999 shlee9999 shlee9999 approved these changes

@kimjuyoung78 kimjuyoung78 Awaiting requested review from kimjuyoung78

@saseungmin saseungmin Awaiting requested review from saseungmin

Assignees

@wonill wonill

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] 반려견 상세정보 입력 기능
3 participants
@wonill @ruehan @shlee9999